ContentService::loadRelations → ContentService::loadRelationList#2544
Merged
Conversation
Fix "Argument #1 ($contentId) must be of type int, string given"
loadRelations is deprecated in 4.5, and removed in 5.0 Fix "Call to an undefined method Ibexa\Contracts\Core\Repository\ContentService::loadRelations()." on PHPStan + 5.0
loadRelations is deprecated in 4.5, and removed in 5.0 Fix "Call to an undefined method Ibexa\Contracts\Core\Repository\ContentService::loadRelations()." on PHPStan + 5.0
3 tasks
ViniTou
reviewed
Nov 20, 2024
ViniTou
approved these changes
Nov 20, 2024
7 tasks
ViniTou
approved these changes
Nov 21, 2024
adriendupuis
commented
Nov 21, 2024
mnocon
reviewed
Nov 25, 2024
mnocon
left a comment
Contributor
There was a problem hiding this comment.
Thank you for taking care of this!
One question aboout the hasRelation usage - and one suggestion for the pagination remark.
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
…ller.php Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
code_samples/ change report
|
adriendupuis
added a commit
that referenced
this pull request
Nov 27, 2024
loadRelations is deprecated in 4.5, and removed in 5.0 --------- Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> (cherry picked from commit e68a80c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentService::loadRelationsis deprecated in 4.6 and won't exist in 5.0 (removal in ibexa/core#435)Previews:
DEFAULT_PAGE_SIZElimit in this one because there is a link to the other page showing pagination and how to get the relation count to trick the pagination to get all the relations in one go.Note: its deprecation is reported in the hidden https://doc.ibexa.co/en/latest/api/php_api/php_api_reference/reports/deprecated.html#vendor/ibexa/core/src/contracts/Repository/ContentService.php
I have checked other elements from this report. ("Not documented" means that the element is nowhere in the documentation text and nowhere in the code examples used by the documentation.)
ContentService::loadContentDrafts()SearchResult::$spellSuggestionAbstractCriterionQueryCriterionMapperInterfaceFieldValueSortClauseSortDirectionSegmentationServiceInterface::loadSegment()SegmentationServiceInterface::loadSegmentGroup()TaxonomyTreeServiceInterface::getPath()Checklist